Feature java8 time #212
Merged
Feature java8 time #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut Year and testFunc
Add localdate、local_date_time、local_time struct
AlexStocks
requested review from
cvictory,
wongoo,
fangyincheng,
hxmhlt and
zouyx
wongoo
reviewed
Jul 27, 2020
zouyx
reviewed
Jul 28, 2020
- add java8-time struct YearMonth and Period - add file License context Co-authored-by: wilson chen <willson.chenwx@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 66.73% 66.85% +0.11%
==========================================
Files 23 24 +1
Lines 2883 2893 +10
==========================================
+ Hits 1924 1934 +10
Misses 744 744
Partials 215 215
Continue to review full report at Codecov.
|
wongoo
approved these changes
Jul 30, 2020
AlexStocks
approved these changes
Aug 1, 2020
|
Hi, thank you maintainers for your review. We will add the rest types soon. |
This was referenced Sep 6, 2020
zhangymPerson
added a commit
to zhangymPerson/dubbo-go-hessian2
that referenced
this pull request
Sep 12, 2020
add support java8 time object. apache#212, apache#221
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Add java8.time support
Which issue(s) this PR fixes:
Fixes #193
Special notes for your reviewer:
Only part of java8.time classes are supported now. Please review our framework of impelement. And we will coding for the reset classes asap if this PR is merged.
java.time.OffsetDateTime
java.time.ZoneOffset
java.time.OffsetTime
java.time.ZoneDateTime
java.time.Year
java.time.YearMonth
java.time.MonthDay
java.time.Instant
java.time.Duration
java.time.Period
java.time.LocalTime
java.time.LocalDate
java.time.LocalDateTime
java.sql.Date
java.sql.Time
java.sql.Timestamp