java.sql.Time & java.sql.Date #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 13, 2020 07:54
AlexStocks
requested review from
gaoxinge and
wongoo
and removed request for
gaoxinge
|
@zhangshen023 pls fix the travis failure. |
|
ok,i will make a try |
added 2 commits
August 16, 2020 15:24
AlexStocks
reviewed
Aug 16, 2020
|
NOT AGREE to add the Date&Time definition in hessian package, and there already java8_time package in which it contains date and time definition. If it's really necessary , suggestion to move to a new package |
good suggestion. |
wongoo
reviewed
Aug 20, 2020
wongoo
approved these changes
Aug 25, 2020
AlexStocks
approved these changes
Aug 27, 2020
zouyx
reviewed
Aug 29, 2020
zouyx
approved these changes
Aug 30, 2020
This was referenced Aug 31, 2020
Merged
zhaoyunxing92
pushed a commit
that referenced
this pull request
Sep 4, 2021
java.sql.Time & java.sql.Date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
java class java.sql.Time & java.sql.Date refer to hessian.Time & hessian.Date
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
can use hessian.Time & hessian.Date in go for communicating with java.sql.Time & java.sql.Date in java