-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr/support register with no pojo object #243
Conversation
@LaurenceLiZhixin I think the func can meet your requirement : |
I think this function can register object, and I actually use this funciton in my code. |
@LaurenceLiZhixin thanks for submit this pr.
|
Codecov Report
@@ Coverage Diff @@
## master #243 +/- ##
==========================================
- Coverage 66.24% 66.10% -0.15%
==========================================
Files 25 25
Lines 2776 2785 +9
==========================================
+ Hits 1839 1841 +2
- Misses 711 716 +5
- Partials 226 228 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix: add not pojo Object register support * fix: change gomod * fix: delete unused comment * chore: rv unused import * fix: change gomod name * Fix: replace go versionon * fix: change the way to encode no pojo interface * fix: change the way to encode no pojo interface * chore: cicd bugs * chore: call cicd * fix: go fmt file * chore: add none pojo check classInfoList * chore: delete pre check of none pojo obj * fix: change perror * fix: use loadPojoRegistry func * chore: error msg fix
What this PR does:
Add not pojo object register support, to support dubbo-go-cli tool.
Before, we can't register an object that made by "reflect.New" because it's not impl pojo interface.
But now, we can register this object, as long as it contains field "JavaClassName"
Which issue(s) this PR fixes:
NONE
Special notes for your reviewer:
Create a function to deal with interface made by reflect, get JavaClassName field and register the object with javaClassName.
Does this PR introduce a user-facing change?:
NONE