-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix emoji decoding error #254
Conversation
Codecov Report
@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 66.19% 67.61% +1.42%
==========================================
Files 25 25
Lines 2801 2671 -130
==========================================
- Hits 1854 1806 -48
+ Misses 718 644 -74
+ Partials 229 221 -8
Continue to review full report at Codecov.
|
benchmark resultbefore fixing:
after fixing:
with 17% performance improvement. |
ci failed |
Fix emoji decoding error
What this PR does:
fix emoji decoding error and refactor string decoding algorithm, with 17% performance improvement
Which issue(s) this PR fixes:
Fixes #252 #253
Special notes for your reviewer:
Does this PR introduce a user-facing change?: