fix registration ignored for struct with same name in diff package #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wongoo 如果不考虑JavaClassName重复注册的话，dubbo-go无须变动 |
暂不考虑，重复JavaClassName的问题应该在象模型设计上就做好区分。 |
|
涉及的面有点多，暂时先关闭 |
added 2 commits
September 22, 2021 15:21
wongoo
reviewed
Sep 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 70.09% 70.21% +0.11%
==========================================
Files 27 27
Lines 3016 3028 +12
==========================================
+ Hits 2114 2126 +12
Misses 677 677
Partials 225 225
Continue to review full report at Codecov.
|
wongoo
reviewed
Sep 22, 2021
wongoo
approved these changes
Sep 22, 2021
|
Pls add unit tests for this pr. maybe some uts for the two new funcs. |
AlexStocks
approved these changes
Sep 25, 2021
AlexStocks
added a commit
that referenced
this pull request
Oct 11, 2021
…st_module_name Fix: modify pr #279 unit test requires module name
wongoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Optimizing the registration go struct name (combine go PkgPath and go Name).
Which issue(s) this PR fixes:
Fixes apache/dubbo-go#1454
Special notes for your reviewer:
Does this PR introduce a user-facing change?: