Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix EOF error check #288

Merged
merged 1 commit into from
Nov 16, 2021
Merged

fix EOF error check #288

merged 1 commit into from
Nov 16, 2021

Conversation

wongoo
Copy link
Contributor

@wongoo wongoo commented Nov 14, 2021

What this PR does:

  • fix EOF error check

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

- fix EOF error check 

@wongoo wongoo requested review from LaurenceLiZhixin, aliiohs, AlexStocks and zouyx and removed request for aliiohs November 14, 2021 08:27
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

Merging #288 (8798395) into master (ad93624) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #288   +/-   ##
=======================================
  Coverage   70.13%   70.13%           
=======================================
  Files          27       27           
  Lines        3034     3034           
=======================================
  Hits         2128     2128           
  Misses        680      680           
  Partials      226      226           
Impacted Files Coverage Δ
decode.go 69.46% <0.00%> (ø)
java_sql_time.go 63.88% <0.00%> (ø)
object.go 65.69% <0.00%> (ø)
list.go 84.61% <100.00%> (ø)
map.go 58.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad93624...8798395. Read the comment docs.

@wongoo wongoo changed the title fix EOF error check & fix go name fix EOF error check Nov 16, 2021
@wongoo
Copy link
Contributor Author

wongoo commented Nov 16, 2021

@justxuewei I have updated this pr, this pr contains only one fix for EOF error check.

@wongoo wongoo merged commit 9653a02 into apache:master Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants