Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix parse basic type bug #298

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Conversation

luky116
Copy link

@luky116 luky116 commented Dec 16, 2021

When accessing a method whose return value is an enume value on the server, the client cannot parse the return value and reports an error. The tracing code found that the client could not convert the enum value type to Int64 type
146210119-13875974-3c51-417f-8415-d190094a2373

You can reproduce the above problem through this code:https://github.com/luky116/dubbo-go-samples/tree/fix-rpcDubbo/rpc/dubbo

@codecov-commenter
Copy link

Codecov Report

Merging #298 (d26d6da) into master (75ff950) will increase coverage by 0.35%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   70.35%   70.70%   +0.35%     
==========================================
  Files          27       27              
  Lines        3049     3021      -28     
==========================================
- Hits         2145     2136       -9     
+ Misses        679      660      -19     
  Partials      225      225              
Impacted Files Coverage Δ
codec.go 75.56% <33.33%> (+4.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75ff950...d26d6da. Read the comment docs.

Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 7f38305 into apache:master Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants