Add:support attachments #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoxinge
reviewed
Jul 12, 2019
wongoo
reviewed
Jul 15, 2019
|
@fangyincheng this pr is not forward compatible, I'd like to merge it to a new branch @AlexStocks FYI |
It is forward compatible. Compatible with previous usage. |
|
@fangyincheng @gaoxinge @hxmhlt @u0x01 all conversions in the pr have being resolved, if there is not any other question, I will merge it tomorrow. |
This was referenced Mar 18, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
RequestandResponseWhich issue(s) this PR fixes:
Fixes #49
Special notes for your reviewer:
Does this PR introduce a user-facing change?: