-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timeout config overridden #190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20210524Merge
Merge20210601
Merge develop
Codecov Report
@@ Coverage Diff @@
## develop #190 +/- ##
===========================================
- Coverage 43.19% 43.14% -0.05%
===========================================
Files 33 33
Lines 1755 1757 +2
===========================================
Hits 758 758
- Misses 888 890 +2
Partials 109 109
Continue to review full report at Codecov.
|
xiaoliu10
approved these changes
Jun 21, 2021
AlexStocks
approved these changes
Jun 22, 2021
williamfeng323
approved these changes
Jun 22, 2021
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR moves the timeout config outside the clusters. In detail, it moves
connect_timeout
andrequest_timeout
fromclusters
intotimeout_config
inconf.yaml
.Which issue(s) this PR fixes:
Fixes #189