Lds basic #417
Merged
Lds basic #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
approved these changes
May 1, 2022
Codecov Report
@@ Coverage Diff @@
## develop #417 +/- ##
===========================================
+ Coverage 36.61% 37.58% +0.96%
===========================================
Files 55 55
Lines 3654 3720 +66
===========================================
+ Hits 1338 1398 +60
- Misses 2164 2166 +2
- Partials 152 156 +4
Continue to review full report at Codecov.
|
ztelur
reviewed
May 8, 2022
| } | ||
|
|
||
| // setupListeners setup listeners accord to dynamic resource | ||
| func (l *LdsManager) setupListeners(listeners []*xdsModel.Listener) { | ||
| //Make sure each one has a unique name like "host-port-protocol" | ||
| for _, v := range listeners { | ||
| v.Name = resolveListenerName(v.Address.SocketAddress.Address, int(v.Address.SocketAddress.Port), v.Protocol.String()) |
There was a problem hiding this comment.
is it possible that v.Name has it's value. check it is nil then call resolveListenerName ?
There was a problem hiding this comment.
The listener’s name is useless now, so just overwritten it. if we need this, then change it later, but not now.
PhilYue
approved these changes
May 8, 2022
ztelur
approved these changes
May 10, 2022
A-Wanderer
pushed a commit
to A-Wanderer/dubbo-go-pixiu
that referenced
this pull request
Jul 21, 2022
* basic * simple reload * simple reload * simple reload * simple reload * simple reload * http2_listener.go * fix ut * dubbo/triple done * dubbo/triple done * ut for lds * switch to github.com/dubbo-go-pixiu/pixiu-api * imports-formatter * fix ci * fix ci * mod fmt * mod fmt Co-authored-by: mark4z <mark4z.vip@gmail.com>
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
* basic * simple reload * simple reload * simple reload * simple reload * simple reload * http2_listener.go * fix ut * dubbo/triple done * dubbo/triple done * ut for lds * switch to github.com/dubbo-go-pixiu/pixiu-api * imports-formatter * fix ci * fix ci * mod fmt * mod fmt Co-authored-by: mark4z <mark4z.vip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
LDS support for each listener
Which issue(s) this PR fixes:
Special notes for your reviewer:
Notes:
Does this PR introduce a user-facing change?: