Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dubbo3 demo #34

Closed
wants to merge 17 commits into from

Conversation

LaurenceLiZhixin
Copy link
Contributor

add dubbo3 demo in general/dubbo3
Pls don't merge until apache/dubbo-go#959 is merge

)

replace github.com/envoyproxy/go-control-plane => github.com/envoyproxy/go-control-plane v0.8.0

replace github.com/apache/dubbo-go v1.5.5 => ../dubbo-go

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after dubbo3.0 merged, I 'll change it

@cityiron
Copy link
Contributor

cityiron commented Feb 6, 2021

If add dubbogo3.0 demo to 3.0 branch?

@LaurenceLiZhixin
Copy link
Contributor Author

If add dubbogo3.0 demo to 3.0 branch?

I think ur right.
Pls add a new 3.0 branch for me.

@cityiron cityiron changed the base branch from master to 3.0 February 7, 2021 06:01
@cityiron
Copy link
Contributor

cityiron commented Feb 7, 2021

If add dubbogo3.0 demo to 3.0 branch?

I think ur right.
Pls add a new 3.0 branch for me.

I changed this PR to 3.0 branch.

fmt.Println("rsp len = ", len(rsp.Data))
time.Sleep(time.Second)

//rsp, err = grpcGreeterImpl.BigUnaryTest(context.Background(), &BigDataReq)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If u do not want to use the following codes, pls delete them.

}
log.Printf("####### get client %+v", r)
fmt.Println("rsp len = ", len(rsp.Data))
////
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete them.

@@ -100,13 +100,19 @@ github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRF
github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d/go.mod h1:rBZYJk541a8SKzHPHnH3zbiI+7dagKZ0cgpgrD7Fyho=
github.com/alibaba/sentinel-golang v0.6.2 h1:1OjjpljJbNKWp9p5RJKxOqS1gHGZPUWPlCcokv5xYJs=
github.com/alibaba/sentinel-golang v0.6.2/go.mod h1:5jemKdyCQCKVf+quEia53fo9a17OSe+wnl9HX2NbNpc=
github.com/alibaba/sentinel-golang v1.0.1 h1:WlhN0XUxRyfkiDc8TO6CcRrnakwFP9zFtvJTYxZRCgI=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using 'go mod tidy' to delete useless old version sentinel-golang.

@@ -4,17 +4,16 @@
application:
organization: "dubbo.io"
name: "GreeterGrpcServer"
module: "dubbo-go greeter grpc server"
module: "dubbo-go3.0 greeter server"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dubbo-go v3

@@ -10,26 +10,24 @@ connect_timeout: "3s"
application:
organization: "dubbo.io"
name: "GreeterGrpcConsumer"
module: "dubbo-go greeter grpc client"
module: "dubbo-go3.0 greeter client"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dubbo-go v3

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make checking success thx.

@LaurenceLiZhixin
Copy link
Contributor Author

After PR: apache/dubbo-go#1071
merged, the existing problems would be fixed.

@LaurenceLiZhixin LaurenceLiZhixin deleted the branch apache:3.0 April 5, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants