Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:zk too many tcp conn #1010

Merged
merged 41 commits into from
Mar 15, 2021
Merged

Conversation

wenxuwan
Copy link
Member

Now every registry have one connection with zk, this is a waste of resources. It is completely unnecessary for dubbo-go to maintain a complex reconnection mechanism, which will increase the number of links and memory of zk.

@cityiron cityiron added this to the v1.5.6 milestone Jan 23, 2021
@AlexStocks AlexStocks force-pushed the develop branch 2 times, most recently from 25c3b98 to 9a666eb Compare January 23, 2021 11:12
Copy link
Contributor

@cityiron cityiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change, ignore

config_center/zookeeper/impl.go Outdated Show resolved Hide resolved
registry/kubernetes/registry.go Outdated Show resolved Hide resolved
registry/zookeeper/listener.go Outdated Show resolved Hide resolved
@cityiron cityiron removed this from the v1.5.6 milestone Jan 24, 2021
Copy link
Contributor

@jack15083 jack15083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore

@codecov-io
Copy link

codecov-io commented Jan 26, 2021

Codecov Report

Merging #1010 (9d8c910) into 1.5 (968650f) will decrease coverage by 0.24%.
The diff coverage is 60.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1010      +/-   ##
==========================================
- Coverage   59.53%   59.28%   -0.25%     
==========================================
  Files         259      268       +9     
  Lines       12737    13016     +279     
==========================================
+ Hits         7583     7717     +134     
- Misses       4199     4336     +137     
- Partials      955      963       +8     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/zone_aware_cluster_invoker.go 64.28% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
cluster/router/tag/router_rule.go 89.47% <ø> (+12.20%) ⬆️
common/config/environment.go 51.72% <ø> (ø)
common/extension/config_post_processor.go 0.00% <0.00%> (ø)
common/extension/conn_checker.go 0.00% <0.00%> (ø)
common/extension/metadata_service.go 0.00% <0.00%> (ø)
common/proxy/proxy_factory/default.go 13.55% <0.00%> (+0.22%) ⬆️
config/base_config.go 64.02% <ø> (ø)
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f81eb...9d8c910. Read the comment docs.

@AlexStocks
Copy link
Contributor

pls change the target branch to 1.5

remoting/exchange_client.go Outdated Show resolved Hide resolved
remoting/exchange_client.go Outdated Show resolved Hide resolved
remoting/exchange_client.go Outdated Show resolved Hide resolved
remoting/zookeeper/client.go Outdated Show resolved Hide resolved
remoting/zookeeper/client.go Outdated Show resolved Hide resolved
remoting/zookeeper/client.go Outdated Show resolved Hide resolved
metadata/report/zookeeper/report.go Show resolved Hide resolved
protocol/dubbo/dubbo_invoker.go Show resolved Hide resolved
registry/zookeeper/service_discovery.go Outdated Show resolved Hide resolved
remoting/exchange_client.go Show resolved Hide resolved
registry/zookeeper/registry.go Outdated Show resolved Hide resolved
registry/zookeeper/registry.go Outdated Show resolved Hide resolved
@wenxuwan wenxuwan requested a review from fangyincheng March 6, 2021 06:58
@AlexStocks AlexStocks force-pushed the 1.5 branch 2 times, most recently from 415e245 to 698908d Compare March 6, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants