Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: integration test in Action #1068

Merged
merged 9 commits into from
Mar 6, 2021
Merged

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Feb 27, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zouyx zouyx added the bug Something isn't working label Feb 27, 2021
@zouyx zouyx marked this pull request as draft February 27, 2021 15:19
@zouyx zouyx changed the title Fix integration test in Action Fix: integration test in Action Feb 27, 2021
@codecov-io
Copy link

Codecov Report

Merging #1068 (3f53972) into 1.5 (968650f) will decrease coverage by 0.09%.
The diff coverage is 60.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1068      +/-   ##
==========================================
- Coverage   59.53%   59.44%   -0.10%     
==========================================
  Files         259      268       +9     
  Lines       12737    13367     +630     
==========================================
+ Hits         7583     7946     +363     
- Misses       4199     4436     +237     
- Partials      955      985      +30     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/zone_aware_cluster_invoker.go 64.28% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
cluster/router/tag/router_rule.go 89.47% <ø> (+12.20%) ⬆️
common/config/environment.go 51.72% <ø> (ø)
common/extension/config_post_processor.go 0.00% <0.00%> (ø)
common/extension/conn_checker.go 0.00% <0.00%> (ø)
common/extension/metadata_service.go 0.00% <0.00%> (ø)
common/proxy/proxy_factory/default.go 13.55% <0.00%> (+0.22%) ⬆️
config/base_config.go 64.02% <ø> (ø)
... and 170 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f81eb...ccbb151. Read the comment docs.

@zouyx zouyx marked this pull request as ready for review March 2, 2021 15:28
@cityiron cityiron added this to the v1.5.7 milestone Mar 6, 2021
@AlexStocks AlexStocks merged commit c8ae5dc into apache:1.5 Mar 6, 2021
AlexStocks added a commit that referenced this pull request Mar 6, 2021
AlexStocks added a commit that referenced this pull request Mar 6, 2021
AlexStocks added a commit that referenced this pull request Mar 6, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants