Ftr: provide a default config #1073
Conversation
Update dubbo_invoker.go
…cribe fix:nacos service provider does not require subscribe
Ftr: Use invoker with same ip as client first.
AlexStocks
requested review from
fangyincheng,
flycash,
aliiohs and
gaoxinge
and removed request for
fangyincheng and
flycash
Sorry, Recently I encountered some difficulties, Now I have changed the way of setting default parameters. It can be passed on my local computer. |
Codecov Report
@@ Coverage Diff @@
## 3.0 #1073 +/- ##
==========================================
- Coverage 60.03% 59.53% -0.51%
==========================================
Files 260 268 +8
Lines 12855 13398 +543
==========================================
+ Hits 7718 7976 +258
- Misses 4174 4438 +264
- Partials 963 984 +21
Continue to review full report at Codecov.
|
| // Even though baseConfig has been initialized, we override it | ||
| // because we think read from config file is correct config | ||
| baseConfig = &providerConfig.BaseConfig | ||
| } | ||
| } | ||
|
|
||
| // setDefaultValue set default value for providerConfig or consumerConfig if it is null | ||
| func setDefaultValue(target interface{}) { |
There was a problem hiding this comment.
Can you use annotation in this line for default value?
There was a problem hiding this comment.
Can you use annotation in this line for default value?
in go we can use annotation as Java?
There was a problem hiding this comment.
let me see see and study study. hhhh
Ftr: provide a default config
What this PR does:
If the path of the configuration file cannot be obtained from the environment variables or the startup parameters, the system will search for the configuration file from the default location. If the configuration file fails to read, the default parameters will be set
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
. ├── app │ ├── client.go │ └── user.go └── profiles ├── client.yml └── log.ymlgo run .