-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add v3router to dubbogo #1187
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #1187 +/- ##
==========================================
- Coverage 59.53% 55.94% -3.60%
==========================================
Files 259 269 +10
Lines 12737 12818 +81
==========================================
- Hits 7583 7171 -412
- Misses 4199 4753 +554
+ Partials 955 894 -61
Continue to review full report at Codecov.
|
cluster/router/v3router/match_judger/double_range_match_judger.go
Outdated
Show resolved
Hide resolved
judger的设计直接依赖于config配置,在运行时依据配置进行判断,都是重复性的工作,看这部分是不是可以优化。每个judger只需依赖自己需要的信息即可。 |
目前来说每个judger是只依赖自己的需要的信息。望哥的意思是不直接依赖于配置?让每个judger自己保存关心的字段么?我觉得可以之后优化一下。 |
是的,可以后续优化 |
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: