reuse MockEventDispatcher and NewMockServiceNameMapping in service discovery test #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #1189 +/- ##
==========================================
- Coverage 59.53% 56.56% -2.97%
==========================================
Files 259 254 -5
Lines 12737 12488 -249
==========================================
- Hits 7583 7064 -519
- Misses 4199 4543 +344
+ Partials 955 881 -74
Continue to review full report at Codecov.
|
|
@gaoxinge , pls check the following files ./common/extension/event_dispatcher.go:56: "like import _ github.com/apache/dubbo-go/common/observer/dispatcher ")
./common/extension/registry.go:35: panic("registry for " + name + " does not exist. please make sure that you have imported the package `github.com/apache/dubbo-go/registry/" + name + "`.")
./common/extension/metadata_remote.go:49: "remote - github.com/apache/dubbo-go/metadata/remote/impl"))
./common/extension/metadata_service_proxy_factory.go:48: "local - github.com/apache/dubbo-go/metadata/service/inmemory, \n", name))
./common/extension/metadata_service.go:53: "local - github.com/apache/dubbo-go/metadata/service/inmemory, "))
./contributing.md:62: "github.com/apache/dubbo-go/common"
./protocol/dubbo3/protoc-gen-dubbo3/go.mod:1:module github.com/apache/dubbo-go/protocol/dubbo3/protoc-gen-dubbo3
./protocol/dubbo3/protoc-gen-dubbo3/main.go:32: _ "github.com/apache/dubbo-go/protocol/dubbo3/protoc-gen-dubbo3/plugin/dubbo3"
./protocol/invoker.go:44://go:generate mockgen -source invoker.go -destination mock/mock_invoker.go -self_package github.com/apache/dubbo-go/protocol/mock --package mock Invoker
./test/integrate/dubbo/go-client/go.mod:1:module github.com/apache/dubbo-go/test/integrate/dubbo/go-client
./test/integrate/dubbo/go-server/go.mod:1:module github.com/apache/dubbo-go/test/integrate/dubbo/go-server
./test/integrate/dubbo/go-server/go.mod:9: // RUN test ${PR_ORIGIN_REPO} && go mod edit -replace=dubbo.apache.org/dubbo-go/v3=github.com/${PR_ORIGIN_REPO}@${PR_ORIGIN_COMMITID} || go get -u dubbo.apache.org/dubbo-go/v3@develop
./tools/cli/go.mod:1:module github.com/apache/dubbo-go/tools/cli
./tools/cli/example/server/go.sum:117:github.com/apache/dubbo-go v1.5.1 h1:9bcGOkek0+x+zqtvykKpuOwkoJfMef0zNxsyPbWOafY=
./tools/cli/example/server/go.sum:118:github.com/apache/dubbo-go v1.5.1/go.mod h1:lxwgtF+27mSFQsSrBLaVbdQpwCp+pBN/mHP4w4/N2Qc=
./tools/cli/example/server/go.sum:119:github.com/apache/dubbo-go v1.5.4 h1:kRVw2p6Fqk5PlJGHeb8IVFg5AuBJFPFvCvRm7/i3Qco=
./tools/cli/example/server/go.sum:120:github.com/apache/dubbo-go v1.5.4/go.mod h1:QIqjEvIbgmuk1mESsQSsTsFngHlYLGAmRN9gXN+YJq4=
./tools/cli/protocol/dubbo/dubbo_protocol.go:33: "github.com/apache/dubbo-go/tools/cli/common"
./tools/cli/protocol/dubbo/dubbo_protocol.go:34: "github.com/apache/dubbo-go/tools/cli/protocol"
./tools/cli/common/protocol.go:21: "github.com/apache/dubbo-go/tools/cli/protocol"
./tools/cli/json_register/json_register.go:32: "github.com/apache/dubbo-go/tools/cli/common"
./tools/cli/client/client.go:33: "github.com/apache/dubbo-go/tools/cli/common"
./tools/cli/client/client.go:34: "github.com/apache/dubbo-go/tools/cli/protocol"
./tools/cli/client/client.go:35: _ "github.com/apache/dubbo-go/tools/cli/protocol/dubbo"
./tools/cli/main.go:26: "github.com/apache/dubbo-go/tools/cli/client"
./tools/cli/main.go:27: "github.com/apache/dubbo-go/tools/cli/json_register" |
LaurenceLiZhixin
approved these changes
May 14, 2021
zhaoyunxing92
approved these changes
May 14, 2021
AlexStocks
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?: