Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 1166: treat all zk child path url as new child #1225

Merged
merged 1 commit into from
May 30, 2021

Conversation

AlexStocks
Copy link
Contributor

What this PR does:

treat all zk child path url as new child

Which issue(s) this PR fixes:

Fixes #1166

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2021

Codecov Report

Merging #1225 (b0485fb) into 1.5 (a10ff4d) will decrease coverage by 7.57%.
The diff coverage is 60.77%.

❗ Current head b0485fb differs from pull request most recent head ccdf33e. Consider uploading reports for the commit ccdf33e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1225      +/-   ##
==========================================
- Coverage   66.13%   58.55%   -7.58%     
==========================================
  Files         174      272      +98     
  Lines        9343    13242    +3899     
==========================================
+ Hits         6179     7754    +1575     
- Misses       2541     4532    +1991     
- Partials      623      956     +333     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (-6.67%) ⬇️
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (-3.53%) ⬇️
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (-4.77%) ⬇️
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
... and 386 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a83480...ccdf33e. Read the comment docs.

Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved these changes

@zouyx zouyx added the enhancement New feature or request label May 29, 2021
@AlexStocks AlexStocks merged commit cdae603 into 1.5 May 30, 2021
@AlexStocks AlexStocks deleted the fix/issue1166 branch June 1, 2021 03:40
@@ -160,10 +160,6 @@ func (l *ZkEventListener) handleZkNodeEvent(zkPath string, children []string, li
newNode string
)
for _, n := range newChildren {
if contains(children, n) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里去掉的话可能会造成goroutine 开启的过多吧 , 应该把之前监听的goroutine 关闭

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方去掉会发生重复监听的。不应该去掉

remoting/zookeeper/listener.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants