-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue 1166: treat all zk child path url as new child #1225
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.5 #1225 +/- ##
==========================================
- Coverage 66.13% 58.55% -7.58%
==========================================
Files 174 272 +98
Lines 9343 13242 +3899
==========================================
+ Hits 6179 7754 +1575
- Misses 2541 4532 +1991
- Partials 623 956 +333
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved these changes
@@ -160,10 +160,6 @@ func (l *ZkEventListener) handleZkNodeEvent(zkPath string, children []string, li | |||
newNode string | |||
) | |||
for _, n := range newChildren { | |||
if contains(children, n) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个地方去掉会发生重复监听的。不应该去掉
What this PR does:
treat all zk child path url as new child
Which issue(s) this PR fixes:
Fixes #1166