Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type; remove useless code #1243

Merged
merged 2 commits into from
Jun 7, 2021
Merged

fix type; remove useless code #1243

merged 2 commits into from
Jun 7, 2021

Conversation

gaoxinge
Copy link

@gaoxinge gaoxinge commented Jun 7, 2021

What this PR does:

  • fix type and remove useless code

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

Codecov Report

Merging #1243 (11e9400) into 3.0 (968650f) will decrease coverage by 3.62%.
The diff coverage is 50.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1243      +/-   ##
==========================================
- Coverage   59.53%   55.90%   -3.63%     
==========================================
  Files         259      272      +13     
  Lines       12737    12882     +145     
==========================================
- Hits         7583     7202     -381     
- Misses       4199     4782     +583     
+ Partials      955      898      -57     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 278 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cd555...11e9400. Read the comment docs.

@AlexStocks AlexStocks merged commit 7ef3eff into apache:3.0 Jun 7, 2021
@gaoxinge gaoxinge deleted the remove branch June 7, 2021 06:10
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants