Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Dead lock when zkListener is added duplicately #1247

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Fix: Dead lock when zkListener is added duplicately #1247

merged 1 commit into from
Jun 7, 2021

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Jun 7, 2021 •
edited
Loading

What this PR does:

  • fix dead lock when listener has been added to pathMap.
  • integrate unit tests for registry/zookeeper/service_discovery_test.go that are dependent on zk.TestCluster

Which issue(s) this PR fixes:

Fixes #1233

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@justxuewei justxuewei changed the title Fix: Dead lock Fix: Dead lock when zkListener is added duplicately Jun 7, 2021
@AlexStocks AlexStocks merged commit ff3c563 into apache:fix/1166-2 Jun 7, 2021
@justxuewei justxuewei deleted the fix/1166-2 branch June 7, 2021 16:53
AlexStocks added a commit that referenced this pull request Jun 8, 2021
@AlexStocks @justxuewei
Fix: as a path for pr 1225 (#1233)
37229e3 
* defeat too much node listen goroutine

* fix dead lock (#1247)

* Fix: assertion bug for asynchronous test for getty (#1248)

* fix dead lock

* Temporarily fix error occurred in getty unit test

* fix testClient_AsyncCall assertion bug

Co-authored-by: XavierNiu <a@nxw.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@georgehao georgehao georgehao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justxuewei @georgehao @AlexStocks