Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add:GetLogger #125

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Add:GetLogger #125

merged 1 commit into from
Jul 9, 2019

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

  • add a function "GetLogger"

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-io
Copy link

Codecov Report

Merging #125 into develop will decrease coverage by 0.23%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
- Coverage       68%   67.76%   -0.24%     
===========================================
  Files           69       69              
  Lines         4354     4356       +2     
===========================================
- Hits          2961     2952       -9     
- Misses        1101     1112      +11     
  Partials       292      292
Impacted Files Coverage Δ
common/logger/logger.go 83.67% <0%> (-3.57%) ⬇️
cluster/cluster_impl/base_cluster_invoker.go 48.93% <0%> (-19.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2c0a9...b9a0f74. Read the comment docs.

@AlexStocks AlexStocks merged commit 8238cab into apache:develop Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants