Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registrys default #1275

Merged
merged 1 commit into from
Jun 25, 2021
Merged

registrys default #1275

merged 1 commit into from
Jun 25, 2021

Conversation

XiaoWeiKIN
Copy link
Contributor

I don't need a default value when I have only configured Registry.

@codecov-commenter
Copy link

Codecov Report

Merging #1275 (9580422) into 3.0 (968650f) will decrease coverage by 3.23%.
The diff coverage is 54.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1275      +/-   ##
==========================================
- Coverage   59.53%   56.30%   -3.24%     
==========================================
  Files         259      273      +14     
  Lines       12737    12822      +85     
==========================================
- Hits         7583     7219     -364     
- Misses       4199     4693     +494     
+ Partials      955      910      -45     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
common/extension/cluster_interceptor.go 0.00% <0.00%> (ø)
common/extension/config_center.go 0.00% <ø> (ø)
common/extension/config_center_factory.go 0.00% <ø> (ø)
... and 286 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f0e1f6...9580422. Read the comment docs.

@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0 milestone Jun 25, 2021
@AlexStocks AlexStocks merged commit cee963f into apache:3.0 Jun 25, 2021
mark4z pushed a commit to mark4z/dubbo-go that referenced this pull request Jul 5, 2021
Co-authored-by: wangxiaowei14227 <wangxiaowei14227@autohome.com.cn>
AlexStocks added a commit that referenced this pull request Jul 5, 2021
…1300)

* build(deps): bump actions/cache from v2.1.4 to v2.1.5

Bumps [actions/cache](https://github.com/actions/cache) from v2.1.4 to v2.1.5.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.4...1a9e213)

Signed-off-by: dependabot[bot] <support@github.com>

* improve etcd version and change create to put (#1203)

* make the package v3router/judger test coverage rate reach 80% (#1260)

* make the package v3router/judger test coverage rate reach 80%

* add router_chain unit test

* refactor imports and some code

* remove blank lines

Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com>

* Fix: Graceful shutdown bugs(supplement #1254) (#1257)

* supplementary fix #1254

remove unused comments

fix import cycle

append apache license header

fix gracefulShutdownFilter unittest bug

go fmt

fix gracefulShutdownConfig unittest bug

fix gracefulShutdownConfig unittest bug

go fmt

* improve formatting based on code style

* go fmt

* set RequestsFinished explicitly

* use mutex to protect variables of ShutdownConfig

* ftr: add config (#1258)

* recover gracefulShutdownFilter logic

* remove unused mutex

Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com>

* refine grpc test code (#1266)

* refine grpc test code

* fix test

* remove useless code

* config test grpc server

* registry 默认值问题 (#1275)

Co-authored-by: wangxiaowei14227 <wangxiaowei14227@autohome.com.cn>

* config center for more parameters (#1277)

* nacos config center optimize

* up remote config

* add protocol chick

* up:代码优化

* go fmt

* fix: add arch picture in readme and delete unused router field. (#1279)

* fix

* fix: delete notify

* performance optimization: change time.After => time.NewTimer

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
Co-authored-by: AlexStocks <alexstocks@foxmail.com>
Co-authored-by: randy <ztelur@gmail.com>
Co-authored-by: LaurenceLiZhixin <382673304@qq.com>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com>
Co-authored-by: XavierNiu <a@nxw.name>
Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com>
Co-authored-by: gaoxinge <xg.gao@tianrang-inc.com>
Co-authored-by: wangxw666 <2484713618@qq.com>
Co-authored-by: wangxiaowei14227 <wangxiaowei14227@autohome.com.cn>
Co-authored-by: 赵云兴 <2385585770@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants