Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "optimize: add lock" #1329

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Conversation

LaurenceLiZhixin
Copy link
Contributor

Reverts #1304

This reverts commit a109967.
@codecov-commenter
Copy link

Codecov Report

Merging #1329 (53f1f7a) into master (a109967) will increase coverage by 2.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
+ Coverage   55.69%   57.72%   +2.02%     
==========================================
  Files         273      274       +1     
  Lines       12830    15173    +2343     
==========================================
+ Hits         7146     8758    +1612     
- Misses       4782     5484     +702     
- Partials      902      931      +29     
Impacted Files Coverage Δ
config/config_loader.go 51.15% <ø> (+3.10%) ⬆️
cluster/router/v3router/uniform_route.go 50.00% <0.00%> (-12.50%) ⬇️
config/instance/metadata_report.go 66.66% <0.00%> (-11.12%) ⬇️
common/yaml/yaml.go 86.66% <0.00%> (-4.25%) ⬇️
filter/filter_impl/token_filter.go 87.50% <0.00%> (-4.17%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 44.82% <0.00%> (-3.96%) ⬇️
protocol/rpc_status.go 45.08% <0.00%> (-3.86%) ⬇️
cluster/cluster_impl/interceptor_invoker.go 50.00% <0.00%> (-3.85%) ⬇️
filter/filter_impl/auth/consumer_sign.go 60.00% <0.00%> (-3.64%) ⬇️
...gistry/event/event_publishing_service_discovery.go 42.10% <0.00%> (-3.61%) ⬇️
... and 265 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a109967...53f1f7a. Read the comment docs.

@LaurenceLiZhixin LaurenceLiZhixin merged commit 808862e into master Jul 18, 2021
ChangedenCZD pushed a commit to chans-open-source/dubbo-go that referenced this pull request Jul 29, 2021
ChangedenCZD pushed a commit to chans-open-source/dubbo-go that referenced this pull request Jul 29, 2021
ChangedenCZD pushed a commit to chans-open-source/dubbo-go that referenced this pull request Jul 29, 2021
ChangedenCZD pushed a commit to chans-open-source/dubbo-go that referenced this pull request Jul 29, 2021
@LaurenceLiZhixin LaurenceLiZhixin deleted the revert-1304-feature/add_lock branch July 29, 2021 14:22
AlexStocks added a commit that referenced this pull request Oct 6, 2021
* improve etcd version and change create to put (#1203)

* fix: CONTRIBUTING.md url error. (#1303)

* add lock (#1304)

* Revert "add lock (#1304)" (#1329)

This reverts commit a109967.

* build(deps): bump github.com/dubbogo/gost from 1.11.14 to 1.11.16 (#1387)

Bumps [github.com/dubbogo/gost](https://github.com/dubbogo/gost) from 1.11.14 to 1.11.16.
- [Release notes](https://github.com/dubbogo/gost/releases)
- [Commits](dubbogo/gost@v1.11.14...v1.11.16)

---
updated-dependencies:
- dependency-name: github.com/dubbogo/gost
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump google.golang.org/protobuf from 1.26.0 to 1.27.1 (#1386)

Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.26.0 to 1.27.1.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash)
- [Commits](protocolbuffers/protobuf-go@v1.26.0...v1.27.1)

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump go.etcd.io/etcd/client/v3 from 3.5.0-alpha.0 to 3.5.0 (#1383)

Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.5.0-alpha.0 to 3.5.0.
- [Release notes](https://github.com/etcd-io/etcd/releases)
- [Changelog](https://github.com/etcd-io/etcd/blob/main/CHANGELOG-3.5.md)
- [Commits](etcd-io/etcd@v3.5.0-alpha.0...v3.5.0)

---
updated-dependencies:
- dependency-name: go.etcd.io/etcd/client/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix provider check

* fix provider check

* fix provider check

Co-authored-by: AlexStocks <alexstocks@foxmail.com>
Co-authored-by: randy <ztelur@gmail.com>
Co-authored-by: LaurenceLiZhixin <382673304@qq.com>
Co-authored-by: Zhiqiang Li <stulzq@qq.com>
Co-authored-by: tyltr <31768692+tylitianrui@users.noreply.github.com>
Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: yuyu.zx <yuyu.zx@alipay.com>
Co-authored-by: fangyincheng <fangyincheng@sina.com>
AlexStocks added a commit that referenced this pull request Oct 25, 2021
* improve etcd version and change create to put (#1203)

* fix: CONTRIBUTING.md url error. (#1303)

* add lock (#1304)

* Revert "add lock (#1304)" (#1329)

This reverts commit a109967.

* build(deps): bump github.com/dubbogo/gost from 1.11.14 to 1.11.16 (#1387)

Bumps [github.com/dubbogo/gost](https://github.com/dubbogo/gost) from 1.11.14 to 1.11.16.
- [Release notes](https://github.com/dubbogo/gost/releases)
- [Commits](dubbogo/gost@v1.11.14...v1.11.16)

---
updated-dependencies:
- dependency-name: github.com/dubbogo/gost
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump google.golang.org/protobuf from 1.26.0 to 1.27.1 (#1386)

Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.26.0 to 1.27.1.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash)
- [Commits](protocolbuffers/protobuf-go@v1.26.0...v1.27.1)

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump go.etcd.io/etcd/client/v3 from 3.5.0-alpha.0 to 3.5.0 (#1383)

Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.5.0-alpha.0 to 3.5.0.
- [Release notes](https://github.com/etcd-io/etcd/releases)
- [Changelog](https://github.com/etcd-io/etcd/blob/main/CHANGELOG-3.5.md)
- [Commits](etcd-io/etcd@v3.5.0-alpha.0...v3.5.0)

---
updated-dependencies:
- dependency-name: go.etcd.io/etcd/client/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix: heartbeat's timeout will modify consumer's timeout

Co-authored-by: AlexStocks <alexstocks@foxmail.com>
Co-authored-by: randy <ztelur@gmail.com>
Co-authored-by: LaurenceLiZhixin <382673304@qq.com>
Co-authored-by: Zhiqiang Li <stulzq@qq.com>
Co-authored-by: tyltr <31768692+tylitianrui@users.noreply.github.com>
Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: yuyu.zx <yuyu.zx@alipay.com>
Co-authored-by: fangyincheng <fangyincheng@sina.com>
justxuewei pushed a commit to justxuewei/dubbo-go that referenced this pull request Oct 28, 2021
* improve etcd version and change create to put (apache#1203)

* fix: CONTRIBUTING.md url error. (apache#1303)

* add lock (apache#1304)

* Revert "add lock (apache#1304)" (apache#1329)

This reverts commit a109967.

* build(deps): bump github.com/dubbogo/gost from 1.11.14 to 1.11.16 (apache#1387)

Bumps [github.com/dubbogo/gost](https://github.com/dubbogo/gost) from 1.11.14 to 1.11.16.
- [Release notes](https://github.com/dubbogo/gost/releases)
- [Commits](dubbogo/gost@v1.11.14...v1.11.16)

---
updated-dependencies:
- dependency-name: github.com/dubbogo/gost
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump google.golang.org/protobuf from 1.26.0 to 1.27.1 (apache#1386)

Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.26.0 to 1.27.1.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash)
- [Commits](protocolbuffers/protobuf-go@v1.26.0...v1.27.1)

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump go.etcd.io/etcd/client/v3 from 3.5.0-alpha.0 to 3.5.0 (apache#1383)

Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.5.0-alpha.0 to 3.5.0.
- [Release notes](https://github.com/etcd-io/etcd/releases)
- [Changelog](https://github.com/etcd-io/etcd/blob/main/CHANGELOG-3.5.md)
- [Commits](etcd-io/etcd@v3.5.0-alpha.0...v3.5.0)

---
updated-dependencies:
- dependency-name: go.etcd.io/etcd/client/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix: heartbeat's timeout will modify consumer's timeout

Co-authored-by: AlexStocks <alexstocks@foxmail.com>
Co-authored-by: randy <ztelur@gmail.com>
Co-authored-by: LaurenceLiZhixin <382673304@qq.com>
Co-authored-by: Zhiqiang Li <stulzq@qq.com>
Co-authored-by: tyltr <31768692+tylitianrui@users.noreply.github.com>
Co-authored-by: Laurence <45508533+LaurenceLiZhixin@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: yuyu.zx <yuyu.zx@alipay.com>
Co-authored-by: fangyincheng <fangyincheng@sina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants