Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Fixed the problem that the timeout period of the original method level does not take effect #1336

Merged
merged 3 commits into from
Jul 29, 2021
Merged

fix Fixed the problem that the timeout period of the original method level does not take effect #1336

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2da1bc3
fix Fixed the problem that the timeout period of the original method …
Jul 22, 2021
c2adbf7
fix Fixed the problem that the timeout period of the original method …
Jul 22, 2021
92ee51c
Merge branch 'apache:3.0' into 3.0
Threadalive Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion protocol/dubbo/dubbo_invoker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,11 @@ func (di *DubboInvoker) Invoke(ctx context.Context, invocation protocol.Invocati

// get timeout including methodConfig
func (di *DubboInvoker) getTimeout(invocation *invocation_impl.RPCInvocation) time.Duration {
timeout := di.GetURL().GetParam(strings.Join([]string{constant.METHOD_KEYS, invocation.MethodName(), constant.TIMEOUT_KEY}, "."), "")
methodName := invocation.MethodName()
if di.GetURL().GetParamBool(constant.GENERIC_KEY, false) {
methodName = invocation.Arguments()[0].(string)
}
timeout := di.GetURL().GetParam(strings.Join([]string{constant.METHOD_KEYS, methodName, constant.TIMEOUT_KEY}, "."), "")
if len(timeout) != 0 {
if t, err := time.ParseDuration(timeout); err == nil {
// config timeout into attachment
Expand Down