Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny optimization: change type to Serializer to avoid type assertion #1448

Merged
merged 18 commits into from
Sep 9, 2021

Conversation

flycash
Copy link
Member

@flycash flycash commented Sep 9, 2021

What this PR does:

A tiny optimization. I found that we have a map which stores the Serializer but the value of this map was declared as interface. So when we want to use it, we have to do type assertion. And I check the code, we could change it to Serializer to make our code clearer.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
I update two public functions. But users should not be able to use those two functions.

NONE

dependabot bot and others added 18 commits April 19, 2021 05:55
Bumps [actions/cache](https://github.com/actions/cache) from v2.1.4 to v2.1.5.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](actions/cache@v2.1.4...1a9e213)

Signed-off-by: dependabot[bot] <support@github.com>
…develop/actions/cache-v2.1.5

build(deps): bump actions/cache from v2.1.4 to v2.1.5
…ache#1387)

Bumps [github.com/dubbogo/gost](https://github.com/dubbogo/gost) from 1.11.14 to 1.11.16.
- [Release notes](https://github.com/dubbogo/gost/releases)
- [Commits](dubbogo/gost@v1.11.14...v1.11.16)

---
updated-dependencies:
- dependency-name: github.com/dubbogo/gost
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…pache#1386)

Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.26.0 to 1.27.1.
- [Release notes](https://github.com/protocolbuffers/protobuf-go/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf-go/blob/master/release.bash)
- [Commits](protocolbuffers/protobuf-go@v1.26.0...v1.27.1)

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
….0 (apache#1383)

Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.5.0-alpha.0 to 3.5.0.
- [Release notes](https://github.com/etcd-io/etcd/releases)
- [Changelog](https://github.com/etcd-io/etcd/blob/main/CHANGELOG-3.5.md)
- [Commits](etcd-io/etcd@v3.5.0-alpha.0...v3.5.0)

---
updated-dependencies:
- dependency-name: go.etcd.io/etcd/client/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1448 (d3bee8f) into develop (d904ed4) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

❗ Current head d3bee8f differs from pull request most recent head 9585288. Consider uploading reports for the commit 9585288 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1448      +/-   ##
===========================================
- Coverage    54.85%   54.83%   -0.03%     
===========================================
  Files          272      272              
  Lines        14746    14746              
===========================================
- Hits          8089     8086       -3     
- Misses        5781     5788       +7     
+ Partials       876      872       -4     
Impacted Files Coverage Δ
protocol/dubbo/impl/serialize.go 0.00% <0.00%> (ø)
protocol/dubbo/impl/codec.go 42.20% <100.00%> (ø)
protocol/dubbo/impl/serialization.go 71.42% <100.00%> (ø)
registry/kubernetes/registry.go 54.28% <0.00%> (-10.48%) ⬇️
remoting/kubernetes/watch.go 80.55% <0.00%> (ø)
remoting/kubernetes/registry_controller.go 55.67% <0.00%> (+1.06%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 78.02% <0.00%> (+2.19%) ⬆️
filter/metrics/filter.go 100.00% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d904ed4...9585288. Read the comment docs.

@AlexStocks AlexStocks changed the base branch from develop to 3.0 September 9, 2021 11:30
@LaurenceLiZhixin LaurenceLiZhixin merged commit cab3893 into apache:3.0 Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants