Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgreade triple pb generate tool #1549

Merged
merged 5 commits into from
Oct 30, 2021
Merged

Upgreade triple pb generate tool #1549

merged 5 commits into from
Oct 30, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Oct 29, 2021 •
edited
Loading

Fix: triple part of #1461 . The protoc-gen-dubbo would be fixed sonn.
Fix： #1460

@LaurenceLiZhixin LaurenceLiZhixin changed the title The problem before release rc-3 [WIP] The problem before release rc-3 Oct 29, 2021
@LaurenceLiZhixin LaurenceLiZhixin changed the title [WIP] The problem before release rc-3 Upgreade triple pb generate tool Oct 29, 2021
zouyx
zouyx reviewed Oct 29, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@LaurenceLiZhixin LaurenceLiZhixin mentioned this pull request Oct 30, 2021
Merged
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2021 •
edited
Loading

Codecov Report

Merging #1549 (8927105) into 3.0 (68ac846) will decrease coverage by 0.10%.
The diff coverage is 48.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1549      +/-   ##
==========================================
- Coverage   41.83%   41.72%   -0.11%     
==========================================
  Files         258      258              
  Lines       15111    15114       +3     
==========================================
- Hits         6321     6307      -14     
- Misses       8057     8068      +11     
- Partials      733      739       +6
Impacted Files Coverage Δ
cluster/router/v3router/router_chain.go 41.80% <0.00%> (-0.35%) ⬇️
config/application_config.go 21.62% <ø> (ø)
config/config_center_config.go 55.33% <0.00%> (ø)
config/consumer_config.go 24.74% <0.00%> (ø)
config/graceful_shutdown.go 0.00% <ø> (ø)
config/logger_config.go 47.45% <ø> (ø)
config/method_config.go 21.05% <ø> (ø)
config/provider_config.go 24.65% <ø> (ø)
config/reference_config.go 0.00% <ø> (ø)
config/router_config.go 5.26% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1521c...8927105. Read the comment docs.

@LaurenceLiZhixin LaurenceLiZhixin merged commit 669ab0a into 3.0 Oct 30, 2021
binbin0325 pushed a commit to binbin0325/dubbo-go that referenced this pull request Nov 6, 2021
@LaurenceLiZhixin @binbin0325
Upgreade triple pb generate tool (apache#1549)
0a435e0 
* fix: update protoc-gen-go-triple

* fix: remove unused file

* fix: metrics update

* fix: linter
@justxuewei justxuewei deleted the ftr/metrics branch August 15, 2022 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjphaha cjphaha cjphaha approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@zouyx zouyx zouyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LaurenceLiZhixin @codecov-commenter @zouyx @AlexStocks @cjphaha