add serviceMappingListener for application service discovery #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request breaks the ci tests, please fix it. |
|
pls fix the ci confliction |
Codecov Report
@@ Coverage Diff @@
## 3.0 #2205 +/- ##
==========================================
- Coverage 44.15% 43.99% -0.16%
==========================================
Files 283 284 +1
Lines 17164 17271 +107
==========================================
+ Hits 7578 7599 +21
- Misses 8789 8872 +83
- Partials 797 800 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bobtthp
requested review from
justxuewei
and removed request for
zhaoyunxing92 and
mark4z
mark4z
approved these changes
Feb 23, 2023
| Group: group, | ||
| }) | ||
| } | ||
|
|
||
| // RegisterServiceAppMapping map the specified Dubbo service interface to current Dubbo app name | ||
| func (n *nacosMetadataReport) RegisterServiceAppMapping(key string, group string, value string) error { | ||
| oldVal, err := n.getConfig(vo.ConfigParam{ |
There was a problem hiding this comment.
OldVal is a list of service names. If strings.Contains(oldVal, newServiceName), then the SNP registration will be skipped, e.g. if oldVal = dubbo.io-2 and newServiceName = dubbo.io, then newServiceName will be skipped.
|
Kudos, SonarCloud Quality Gate passed!
|
|
lgtm |
justxuewei
approved these changes
Mar 7, 2023
AlexStocks
approved these changes
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #2167
support add service mapping listen for service change