-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose TLSConfig for config api #2245
Conversation
Signed-off-by: sekfung <sekfung.lau@gmail.com>
It seems that a TLS test fails. Please check and fix it. |
OK, I will fix it |
@justxuewei hi, plz review the changes when you are free, thx |
It looks like your commits modify tons of comments, why? What formatting tools are you using? Plus, please add an Apache header for |
|
The comments have been heavily modified, which is unrelated to this pull request's topic, so we need to revert them back. I'll run formatting tools on my local environment to investigate what's causing the issue. Is your go version 1.20? |
yes, go version 1.20 |
Signed-off-by: sekfung <sekfung.lau@gmail.com>
Signed-off-by: sekfung <sekfung.lau@gmail.com>
Kudos, SonarCloud Quality Gate passed! |
It seems that the cert file path was not correct Does the CI workflow work correctly? I had not changed the logic which read cert. Just expose tls config for config api Other PR has the same error |
The directory for certificates is hard-coded. It works for the integrated tests of dubbo-go-sample, but it does not work for dubbo-go. I'll let you know if it is fixed. |
ok, thx for your kindness |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks @sekfung!
What this PR does:
expose TLSConfig for config api
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed