Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add request processing total and request succeed total metrics #2331

Merged
merged 7 commits into from
Jun 12, 2023

Conversation

ev1lQuark
Copy link
Contributor

New Metrics:

  1. RequestProcessingTotal: dubbo_provider_requests_processing_total, dubbo_provider_requests_processing_total
  2. RequestSucceedTotal: dubbo_provider_requests_succeed_total, dubbo_provider_requests_succeed_total

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #2331 (ad55d34) into main (95b463b) will increase coverage by 0.16%.
The diff coverage is 82.19%.

❗ Current head ad55d34 differs from pull request most recent head 0c7ddbe. Consider uploading reports for the commit 0c7ddbe to get more accurate results

@@            Coverage Diff             @@
##             main    #2331      +/-   ##
==========================================
+ Coverage   44.10%   44.27%   +0.16%     
==========================================
  Files         294      295       +1     
  Lines       17890    17932      +42     
==========================================
+ Hits         7890     7939      +49     
+ Misses       9161     9148      -13     
- Partials      839      845       +6     
Impacted Files Coverage Δ
filter/metrics/filter.go 73.91% <0.00%> (-11.09%) ⬇️
metrics/prometheus/after_invocation.go 69.23% <71.42%> (-25.06%) ⬇️
metrics/prometheus/before_invocation.go 77.77% <77.77%> (ø)
metrics/prometheus/reporter.go 73.33% <80.00%> (+20.00%) ⬆️
metrics/prometheus/common.go 45.68% <100.00%> (+16.09%) ⬆️
metrics/prometheus/metric_set.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit 95accbd into apache:main Jun 12, 2023
@ev1lQuark ev1lQuark deleted the dev branch June 14, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants