Fix zookeeper and nacos issues working as registry, metadata and configcenter #2369
Conversation
# Conflicts: # go.mod # go.sum
# Conflicts: # registry/base_registry.go
Codecov Report
@@ Coverage Diff @@
## main #2369 +/- ##
==========================================
- Coverage 45.83% 44.80% -1.03%
==========================================
Files 270 270
Lines 18649 18338 -311
==========================================
- Hits 8547 8216 -331
- Misses 9209 9237 +28
+ Partials 893 885 -8
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# Conflicts: # registry/servicediscovery/service_instances_changed_listener_impl.go
Makefile
Outdated
| .PHONE: fmt | ||
| fmt: | ||
| $(GO_GET) -u github.com/dubbogo/tools/cmd/imports-formatter | ||
| imports-formatter | ||
|
|
There was a problem hiding this comment.
Please open a new pull request to add this feature. Keep a pull request to implement only one function as much as possible to make code review easier.
There was a problem hiding this comment.
I will create a new pull request for this part.
|
Could you split this pull request into several pull requests and give a description about this pull request? I noticed this pull request includes several parts. Ideally, one pull request only does one thing, e.g. introduce one feature, fix one bug. Of course, it can also be adjusted according to the actual situation. |
|
Please see the description I leave above. I understand it would be ideal if we submit a pull request containing only changes fixing exactly one issue. In my case here, I don't have a very clear boundary of which issue I am targeting, so the standard I use is to make Nacos being able to work together with Admin. |
|
Kudos, SonarCloud Quality Gate passed!
|
# Conflicts: # go.mod # metrics/prometheus/reporter.go # metrics/rpc/util.go # registry/servicediscovery/service_instances_changed_listener_impl.go
|
Kudos, SonarCloud Quality Gate passed!
|
As titled, I tested dubbo-go Nacos and Zookeeper implementation working as registry, metadata, and configcenter in dubbo admin.
The changes in this pull request are bugfixes made to different parts that finally make admin work.