fix dead lock #2716
Merged
fix dead lock #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 25, 2024 12:49
Signed-off-by: YarBor <yarbor.ww@gmail.com>
Signed-off-by: YarBor <yarbor.ww@gmail.com>
FoghostCn
requested changes
Jul 26, 2024
added 2 commits
July 26, 2024 11:14
Signed-off-by: YarBor <yarbor.ww@gmail.com>
FinalT
requested changes
Jul 26, 2024
There was a problem hiding this comment.
plz write unit test like other routers
cluster/router/script/router_test.go
Outdated
Comment on lines
157
to
159
| want: func(invokers []protocol.Invoker) bool { | ||
| return true | ||
| }, |
cluster/router/script/router_test.go
Outdated
Comment on lines
129
to
131
| want: func(invokers []protocol.Invoker) bool { | ||
| return true | ||
| }, |
There was a problem hiding this comment.
expect to do nothing，the script will make panic, and recover, then ignore script route
Signed-off-by: YarBor <yarbor.ww@gmail.com>
|
|
先不要着急合并，看下 ci 为啥没过 |
There were environmental issues on the CI platform that caused all PRs to fail. We need to find time to take a closer look and fix them before the official version. The current user is waiting to verify the new version, so we need to merge it first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.