Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add : delete mock json in test case of apollo #304

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Jan 6, 2020

What this PR does:

delete mock json in test case of apollo when cases finished

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #304 into develop will decrease coverage by 0.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #304      +/-   ##
===========================================
- Coverage    66.58%   65.82%   -0.76%     
===========================================
  Files          112      113       +1     
  Lines         7182     7239      +57     
===========================================
- Hits          4782     4765      -17     
- Misses        1934     2005      +71     
- Partials       466      469       +3
Impacted Files Coverage Δ
protocol/dubbo/pool.go 59.51% <0%> (-15.13%) ⬇️
protocol/dubbo/listener.go 50.28% <0%> (-10.41%) ⬇️
protocol/dubbo/codec.go 70.27% <0%> (-5.41%) ⬇️
protocol/dubbo/readwriter.go 68.29% <0%> (-2.44%) ⬇️
remoting/zookeeper/listener.go 46.9% <0%> (-1.04%) ⬇️
remoting/zookeeper/client.go 63.87% <0%> (-0.58%) ⬇️
filter/impl/hystrix_filter.go
filter/impl/active_filter.go
filter/impl/graceful_shutdown_filter.go
filter/impl/token_filter.go
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f84dc...e7aa7e5. Read the comment docs.

@zouyx
Copy link
Member Author

zouyx commented Jan 7, 2020

@flycash @fangyincheng check again pls.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit e8cc8c7 into apache:develop Jan 7, 2020
@zouyx zouyx deleted the feature/deleteMockJson branch January 11, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants