Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: TracingFilter #325

Closed
wants to merge 61 commits into from
Closed

Conversation

flycash
Copy link
Member

@flycash flycash commented Jan 14, 2020

What this PR does:

Implementing tracing filter by using opentracing API.

Which issue(s) this PR fixes:

Fixes #321

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@@ -20,15 +20,17 @@ package invocation
import (
"reflect"
"sync"

"github.com/apache/dubbo-go/common"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split?

Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any other code that hasn't been submitted

filter/filter_impl/tracing_filter.go Outdated Show resolved Hide resolved
@flycash flycash closed this Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants