Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rest protocol #370

Merged
merged 3 commits into from
Feb 23, 2020
Merged

Conversation

Patrick0308
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #370 into feature/rest will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           feature/rest    #370      +/-   ##
===============================================
+ Coverage         66.75%   66.9%   +0.14%     
===============================================
  Files               158     158              
  Lines              8230    8230              
===============================================
+ Hits               5494    5506      +12     
+ Misses             2210    2200      -10     
+ Partials            526     524       -2
Impacted Files Coverage Δ
config_center/nacos/client.go 57.26% <0%> (+1.7%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 80.64% <0%> (+2.15%) ⬆️
config_center/nacos/facade.go 62.5% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ac514...c8a5d15. Read the comment docs.

@AlexStocks
Copy link
Contributor

LGTM

@AlexStocks AlexStocks merged commit 4738480 into apache:feature/rest Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants