Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service discovery #385

Merged
merged 3 commits into from
Mar 3, 2020
Merged

Conversation

flycash
Copy link
Member

@flycash flycash commented Mar 3, 2020

What this PR does:

The necessary interface definition of align with dubbo2.7.5

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature/dubbo-2.7.5@5ce2598). Click here to learn what that means.
The diff coverage is 64.48%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             feature/dubbo-2.7.5     #385   +/-   ##
======================================================
  Coverage                       ?   66.72%           
======================================================
  Files                          ?      150           
  Lines                          ?     7963           
  Branches                       ?        0           
======================================================
  Hits                           ?     5313           
  Misses                         ?     2146           
  Partials                       ?      504
Impacted Files Coverage Δ
filter/filter_impl/auth/sign_util.go 69.23% <ø> (ø)
filter/filter_impl/auth/provider_auth.go 52.94% <ø> (ø)
filter/filter_impl/auth/default_authenticator.go 80% <ø> (ø)
filter/filter_impl/auth/accesskey_storage.go 100% <ø> (ø)
filter/filter_impl/auth/consumer_sign.go 60% <ø> (ø)
protocol/dubbo/client.go 68.75% <0%> (ø)
remoting/zookeeper/listener.go 52.57% <100%> (ø)
config_center/nacos/factory.go 12.5% <12.5%> (ø)
config_center/nacos/client.go 57.26% <57.26%> (ø)
config_center/nacos/facade.go 64.7% <64.7%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ce2598...23e1268. Read the comment docs.

@hxmhlt hxmhlt merged commit bc31a84 into apache:feature/dubbo-2.7.5 Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants