Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rest protocol #387

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Fix Rest protocol #387

merged 3 commits into from
Mar 4, 2020

Conversation

Patrick0308
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #387 into feature/rest will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           feature/rest     #387      +/-   ##
================================================
- Coverage          66.9%   66.78%   -0.13%     
================================================
  Files               158      158              
  Lines              8230     8230              
================================================
- Hits               5506     5496      -10     
- Misses             2200     2209       +9     
- Partials            524      525       +1
Impacted Files Coverage Δ
common/extension/rest_server.go 0% <ø> (ø) ⬆️
common/extension/rest_config_reader.go 0% <ø> (ø) ⬆️
common/extension/rest_client.go 0% <ø> (ø) ⬆️
config_center/nacos/facade.go 37.5% <0%> (-25%) ⬇️
config_center/nacos/client.go 55.55% <0%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8a5d15...5add5e2. Read the comment docs.

@flycash flycash merged commit 4b01d83 into apache:feature/rest Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants