Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if zkJar not exist,it will download it. #393

Merged
merged 2 commits into from
Mar 8, 2020

Conversation

Patrick0308
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #393 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #393      +/-   ##
==========================================
- Coverage    67.35%   67.3%   -0.05%     
==========================================
  Files          161     161              
  Lines         8331    8331              
==========================================
- Hits          5611    5607       -4     
- Misses        2198    2201       +3     
- Partials       522     523       +1
Impacted Files Coverage Δ
filter/filter_impl/hystrix_filter.go 68.64% <0%> (-3.39%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0%> (-2.16%) ⬇️
protocol/dubbo/client.go 69.09% <0%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab850a4...62840ac. Read the comment docs.

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks
Copy link
Contributor

LGTM

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyincheng fangyincheng merged commit a7ae33f into apache:develop Mar 8, 2020
@Patrick0308 Patrick0308 deleted the modify-ut-shell branch March 9, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants