Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: kubernetes registry and remote package unit test #400

Merged
merged 66 commits into from
Mar 16, 2020
Merged

Add: kubernetes registry and remote package unit test #400

merged 66 commits into from
Mar 16, 2020

Conversation

sxllwx
Copy link
Member

@sxllwx sxllwx commented Mar 13, 2020 •
edited by AlexStocks
Loading

What this PR does:

Add unit test for kubernetes registry package and remote package.

hxmhlt and others added 20 commits October 30, 2019 21:32
@sxllwx sxllwx requested a review from flycash March 13, 2020 09:31
@AlexStocks
Copy link
Contributor

@NameHaibinZhang pls review this pr.

@AlexStocks
Copy link
Contributor

@sxllwx pls check the travis.

@sxllwx
Copy link
Member Author

sxllwx commented Mar 14, 2020

@sxllwx pls check the travis.
I had resovle this bug in last commit~

@codecov-io
Copy link

codecov-io commented Mar 14, 2020 •
edited
Loading

Codecov Report

Merging #400 into develop will decrease coverage by 0.33%.
The diff coverage is 63.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #400      +/-   ##
===========================================
- Coverage    67.46%   67.13%   -0.34%     
===========================================
  Files          169      174       +5     
  Lines         8579     9262     +683     
===========================================
+ Hits          5788     6218     +430     
- Misses        2247     2443     +196     
- Partials       544      601      +57
Impacted Files Coverage Δ
registry/zookeeper/listener.go 65.38% <100%> (+4.51%) ⬆️
remoting/etcdv3/listener.go 46.08% <100%> (ø) ⬆️
remoting/kubernetes/listener.go 57% <57%> (ø)
remoting/kubernetes/client.go 58.03% <58.03%> (ø)
registry/kubernetes/registry.go 59.81% <59.81%> (ø)
registry/kubernetes/listener.go 72.34% <72.34%> (ø)
remoting/zookeeper/listener.go 52.54% <75%> (-0.03%) ⬇️
remoting/kubernetes/watch.go 80% <80%> (ø)
registry/etcdv3/listener.go 72.34% <85.71%> (-4.41%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfbd042...0769966. Read the comment docs.

AlexStocks
AlexStocks reviewed Mar 14, 2020
View reviewed changes
registry/kubernetes/listener.go Outdated Show resolved Hide resolved
registry/kubernetes/listener.go Outdated Show resolved Hide resolved
registry/kubernetes/listener.go Show resolved Hide resolved
registry/kubernetes/registry.go Outdated Show resolved Hide resolved
registry/kubernetes/registry.go Outdated Show resolved Hide resolved
remoting/kubernetes/client.go Outdated Show resolved Hide resolved
remoting/kubernetes/client.go Show resolved Hide resolved
AlexStocks
AlexStocks reviewed Mar 14, 2020
View reviewed changes
remoting/kubernetes/store.go Outdated Show resolved Hide resolved
remoting/kubernetes/store_test.go Outdated Show resolved Hide resolved
remoting/kubernetes/store_test.go Outdated Show resolved Hide resolved
remoting/kubernetes/store_test.go Outdated Show resolved Hide resolved
remoting/kubernetes/store_test.go Outdated Show resolved Hide resolved
remoting/kubernetes/store.go Outdated Show resolved Hide resolved
remoting/kubernetes/listener.go Show resolved Hide resolved
@AlexStocks
Copy link
Contributor

LGTM

fangyincheng
fangyincheng approved these changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flycash
flycash reviewed Mar 16, 2020
View reviewed changes
registry/kubernetes/registry.go Show resolved Hide resolved
registry/kubernetes/registry.go Outdated Show resolved Hide resolved
remoting/kubernetes/listener.go Show resolved Hide resolved
zouyx
zouyx reviewed Mar 16, 2020
View reviewed changes
go.mod Show resolved Hide resolved
go.mod Show resolved Hide resolved
registry/kubernetes/registry.go Show resolved Hide resolved
registry/kubernetes/registry.go Outdated Show resolved Hide resolved
zouyx
zouyx reviewed Mar 16, 2020
View reviewed changes
registry/etcdv3/listener_test.go Outdated Show resolved Hide resolved
registry/kubernetes/registry.go Show resolved Hide resolved
remoting/etcdv3/client_test.go Outdated Show resolved Hide resolved
remoting/kubernetes/client.go Outdated Show resolved Hide resolved
zouyx
zouyx approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flycash
flycash approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flycash flycash merged commit e8f7526 into apache:develop Mar 16, 2020
@sxllwx sxllwx deleted the k8s_merge branch May 18, 2020 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks left review comments

@zouyx zouyx zouyx approved these changes

@flycash flycash flycash approved these changes

@fangyincheng fangyincheng fangyincheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sxllwx @AlexStocks @codecov-io @zouyx @flycash @fangyincheng @hxmhlt