-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge from develop & refact config reader #410
Conversation
user can add attachment
Add: Grpc tracing for client and server
Mod: delete a judgment condition
Fix: problem in before_ut.bat
Codecov Report
@@ Coverage Diff @@
## feature/rest #410 +/- ##
================================================
- Coverage 67.63% 67.44% -0.20%
================================================
Files 170 169 -1
Lines 8655 8579 -76
================================================
- Hits 5854 5786 -68
+ Misses 2256 2249 -7
+ Partials 545 544 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find out that users may be confused about the config reader because only rest protocol uses this interface. But the most important config like application config, consumer config, provider config... do not use this interface.
It should be refactored in the future.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: