Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge from develop & refact config reader #410

Merged
merged 30 commits into from
Mar 15, 2020

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Mar 15, 2020

Codecov Report

Merging #410 into feature/rest will decrease coverage by 0.19%.
The diff coverage is 55.71%.

Impacted file tree graph

@@               Coverage Diff                @@
##           feature/rest     #410      +/-   ##
================================================
- Coverage         67.63%   67.44%   -0.20%     
================================================
  Files               170      169       -1     
  Lines              8655     8579      -76     
================================================
- Hits               5854     5786      -68     
+ Misses             2256     2249       -7     
+ Partials            545      544       -1     
Impacted Files Coverage Δ
common/extension/confit_reader.go 0.00% <0.00%> (ø)
config/base_config.go 64.14% <ø> (ø)
config/generic_service.go 0.00% <ø> (ø)
config_center/parser/configuration_parser.go 2.25% <0.00%> (+0.17%) ⬆️
config/config_loader.go 56.91% <14.28%> (-6.81%) ⬇️
common/proxy/proxy.go 93.06% <25.00%> (-1.98%) ⬇️
protocol/rest/config/reader/rest_config_reader.go 80.26% <81.81%> (ø)
common/yaml/yaml.go 100.00% <100.00%> (ø)
config/consumer_config.go 56.25% <100.00%> (+0.93%) ⬆️
config/provider_config.go 59.37% <100.00%> (+1.31%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c53128...17c29b5. Read the comment docs.

Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find out that users may be confused about the config reader because only rest protocol uses this interface. But the most important config like application config, consumer config, provider config... do not use this interface.

It should be refactored in the future.

config/consumer_config.go Outdated Show resolved Hide resolved
common/extension/confit_reader.go Show resolved Hide resolved
@fangyincheng fangyincheng merged commit a4c9d8c into apache:feature/rest Mar 15, 2020
@fangyincheng fangyincheng deleted the feature/rest branch March 21, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants