Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service name mapping support #453

Merged
merged 5 commits into from
Apr 2, 2020

Conversation

flycash
Copy link
Member

@flycash flycash commented Mar 24, 2020

What this PR does:

Which issue(s) this PR fixes:

Fixes #419

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #453 into feature/dubbo-2.7.5 will increase coverage by 0.29%.
The diff coverage is 66.66%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feature/dubbo-2.7.5     #453      +/-   ##
=======================================================
+ Coverage                66.93%   67.22%   +0.29%     
=======================================================
  Files                      176      177       +1     
  Lines                     9342     9374      +32     
=======================================================
+ Hits                      6253     6302      +49     
+ Misses                    2476     2458      -18     
- Partials                   613      614       +1
Impacted Files Coverage Δ
config_center/apollo/impl.go 82.71% <0%> (-2.1%) ⬇️
config_center/nacos/impl.go 71.08% <0%> (-1.76%) ⬇️
config_center/zookeeper/impl.go 47.5% <58.33%> (+3.46%) ⬆️
metadata/dynamic_mapping/service_name_mapping.go 88.23% <88.23%> (ø)
cluster/cluster_impl/failback_cluster_invoker.go 78.49% <0%> (-2.16%) ⬇️
protocol/dubbo/readwriter.go 70.73% <0%> (+2.43%) ⬆️
remoting/kubernetes/listener.go 65.42% <0%> (+2.8%) ⬆️
protocol/dubbo/pool.go 81.27% <0%> (+4.56%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adae0d7...1aaeb4c. Read the comment docs.

config_center/apollo/impl.go Show resolved Hide resolved
config_center/zookeeper/impl.go Outdated Show resolved Hide resolved
@AlexStocks
Copy link
Contributor

hi, guy, is it a good idea naming a package like " dynamic_mapping" or "in_memory"? I do not think so.

@hxmhlt
Copy link
Contributor

hxmhlt commented Mar 28, 2020

hi, guy, is it a good idea naming a package like " dynamic_mapping" or "in_memory"? I do not think so.

Or dynamicmapping and inmemory without _
I found other project is named the package like this.

@flycash
Copy link
Member Author

flycash commented Mar 29, 2020

I don't know what is the common practice in Golang. Following the common practice is a good idea.

@AlexStocks
Copy link
Contributor

I don't know what is the common practice in Golang. Following the common practice is a good idea.

refers to the package name in github.com/golang/go.

@zouyx
Copy link
Member

zouyx commented Mar 29, 2020

what about mapping/dynamic and mapping/memory

Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@hxmhlt hxmhlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flycash flycash merged commit e3a4992 into apache:feature/dubbo-2.7.5 Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants