-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service name mapping support #453
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #453 +/- ##
=======================================================
+ Coverage 66.93% 67.22% +0.29%
=======================================================
Files 176 177 +1
Lines 9342 9374 +32
=======================================================
+ Hits 6253 6302 +49
+ Misses 2476 2458 -18
- Partials 613 614 +1
Continue to review full report at Codecov.
|
hi, guy, is it a good idea naming a package like " dynamic_mapping" or "in_memory"? I do not think so. |
Or |
I don't know what is the common practice in Golang. Following the common practice is a good idea. |
refers to the package name in github.com/golang/go. |
what about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Which issue(s) this PR fixes:
Fixes #419
Special notes for your reviewer:
Does this PR introduce a user-facing change?: