Optimizing the interface of RestServer and RestClient #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #460 +/- ##
===========================================
- Coverage 66.83% 66.76% -0.07%
===========================================
Files 177 177
Lines 9359 9368 +9
===========================================
Hits 6255 6255
- Misses 2487 2495 +8
- Partials 617 618 +1
Continue to review full report at Codecov.
|
Patrick0308
changed the title
AlexStocks
reviewed
Apr 1, 2020
zouyx
reviewed
Apr 1, 2020
flycash
reviewed
Apr 1, 2020
flycash
approved these changes
Apr 2, 2020
zouyx
approved these changes
Apr 3, 2020
There was a problem hiding this comment.
Have you retest rest samples in dubbo-samples ? @Patrick0308
fangyincheng
reviewed
Apr 3, 2020
AlexStocks
approved these changes
Apr 5, 2020
|
I remove the category of consumer's url. It test ok. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #460 +/- ##
===========================================
+ Coverage 66.83% 66.93% +0.10%
===========================================
Files 177 177
Lines 9359 9367 +8
===========================================
+ Hits 6255 6270 +15
+ Misses 2487 2479 -8
- Partials 617 618 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
To define RestServerRequest and RestServerResponse, make it very easy for users to implement RestServer interface.