Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simplified attribute in registry config #474

Merged
merged 10 commits into from
Apr 13, 2020
Merged

Conversation

gaoxinge
Copy link

@gaoxinge gaoxinge commented Apr 11, 2020

What this PR does:

  • add simplified attribute in registry config

Special notes for your reviewer:

Adding a simplified attribute in registry config is for:

  • Firstly, there is a simplified attribute in java version.

  • Secondly, simplified provider urls can release the pressure of the registry center. And we can move other parameters in provider ursl to metedata center and config center.

The code follows the java version, but not strictly.

Does this PR introduce a user-facing change?:

NONE

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis still failing

common/url.go Outdated Show resolved Hide resolved
common/url.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Apr 11, 2020

Codecov Report

Merging #474 into develop will increase coverage by 0.04%.
The diff coverage is 47.36%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #474      +/-   ##
===========================================
+ Coverage    66.45%   66.50%   +0.04%     
===========================================
  Files          184      184              
  Lines         9683     9696      +13     
===========================================
+ Hits          6435     6448      +13     
- Misses        2607     2610       +3     
+ Partials       641      638       -3     
Impacted Files Coverage Δ
common/url.go 67.27% <42.85%> (-3.89%) ⬇️
config/registry_config.go 78.94% <50.00%> (-1.06%) ⬇️
registry/protocol/protocol.go 80.80% <66.66%> (-0.48%) ⬇️
protocol/dubbo/client.go 69.09% <0.00%> (+1.21%) ⬆️
config_center/nacos/client.go 57.26% <0.00%> (+1.70%) ⬆️
cluster/cluster_impl/failback_cluster_invoker.go 80.64% <0.00%> (+2.15%) ⬆️
filter/filter_impl/hystrix_filter.go 72.03% <0.00%> (+3.38%) ⬆️
config_center/nacos/facade.go 62.50% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 862bf03...8d92fcb. Read the comment docs.

Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

common/url.go Outdated Show resolved Hide resolved
common/url.go Outdated Show resolved Hide resolved
@flycash flycash merged commit c8f66ac into apache:develop Apr 13, 2020
@gaoxinge gaoxinge deleted the simplified branch April 13, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants