-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add simplified attribute in registry config #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis still failing
Codecov Report
@@ Coverage Diff @@
## develop #474 +/- ##
===========================================
+ Coverage 66.45% 66.50% +0.04%
===========================================
Files 184 184
Lines 9683 9696 +13
===========================================
+ Hits 6435 6448 +13
- Misses 2607 2610 +3
+ Partials 641 638 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Special notes for your reviewer:
Adding a simplified attribute in registry config is for:
Firstly, there is a simplified attribute in java version.
Secondly, simplified provider urls can release the pressure of the registry center. And we can move other parameters in provider ursl to metedata center and config center.
The code follows the java version, but not strictly.
Does this PR introduce a user-facing change?: