-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: start provider with random port #476
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #476 +/- ##
===========================================
+ Coverage 66.39% 66.51% +0.12%
===========================================
Files 184 184
Lines 9700 9718 +18
===========================================
+ Hits 6440 6464 +24
+ Misses 2624 2616 -8
- Partials 636 638 +2
Continue to review full report at Codecov.
|
there are three things left to do. Number 1, wait for the latest dubbogo/getty pr. Number 2, @zouyx pls change your example in ur first comment to let followers know how to use this feature clearly. for examples:
or
or other examples. Number 3, if the server or the server examples of dubbo-samples do not support set ip, pls add or improve it if you think the binding-ip is a important feature. |
I think this is the best implement in random port , because it compatibility with rest:
jsonrpc: dubbo-go/protocol/jsonrpc/server.go Line 232 in f1de848
grpc: dubbo-go/protocol/grpc/server.go Line 103 in f1de848
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: