Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: add comment and modify log level #492

Merged
merged 1 commit into from
Apr 27, 2020

Conversation

fangyincheng
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #492 into develop will increase coverage by 0.24%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #492      +/-   ##
===========================================
+ Coverage    66.44%   66.69%   +0.24%     
===========================================
  Files          184      184              
  Lines         9700     9700              
===========================================
+ Hits          6445     6469      +24     
+ Misses        2620     2595      -25     
- Partials       635      636       +1     
Impacted Files Coverage Δ
common/proxy/proxy.go 93.06% <ø> (ø)
common/rpc_service.go 86.25% <ø> (ø)
common/url.go 67.68% <ø> (ø)
...lter/filter_impl/tps/tps_limiter_method_service.go 80.00% <ø> (ø)
protocol/dubbo/client.go 67.87% <ø> (ø)
protocol/dubbo/codec.go 77.50% <ø> (+5.00%) ⬆️
protocol/dubbo/config.go 13.15% <ø> (ø)
protocol/dubbo/dubbo_exporter.go 100.00% <ø> (ø)
protocol/dubbo/dubbo_invoker.go 82.25% <ø> (ø)
protocol/dubbo/dubbo_protocol.go 91.83% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42dbf0d...f04c170. Read the comment docs.

@@ -59,7 +59,6 @@ type AsyncCallback func(response CallbackResponse)
// return map[string][string]{}
// }
const (
// METHOD_MAPPER ...
METHOD_MAPPER = "MethodMapper"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add comment for this variable?

@flycash flycash merged commit b5d169c into apache:develop Apr 27, 2020
@fangyincheng fangyincheng deleted the add-comment branch May 4, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants