-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imp: refactor the network transport layer #495
Merged
hxmhlt
merged 22 commits into
apache:feature/dubbo-protocol-restructure
from
cvictory:getty_reactor
Jun 4, 2020
Merged
Changes from 14 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
1eb4a83
getty refactor
cvictory fa61e9d
refactor getty
cvictory 0ba15c8
refactor getty
cvictory 9bc37f3
Merge branch 'master' of github.com:apache/dubbo-go into getty_reactor
cvictory c67d34a
fix review issue
cvictory acc7c79
fix review issue
cvictory d48fd1e
remove unused code, add license
cvictory 58e7e86
fix review issue: add comment and some optimization
cvictory adb55ce
split import sentense, fix some review
cvictory 1bbe0b4
modify log
cvictory dc2b68f
fix run issue
cvictory fe3c5b0
fix issue: create gettyClientConn every time
cvictory 1e07952
fix : url.getPath contains slash, but it don't in dubbo-java
cvictory c6abc0d
unit test
cvictory 15608af
fix review issue
cvictory cbac0c9
remove unused code
cvictory 7f9c7a4
reactor import
cvictory 7c30fdc
fix review issue
cvictory dd36c9c
fix review issue
cvictory 713fcf9
fix review issue
cvictory a08d2c7
fix review issue
cvictory 5ba2307
refactor ServiceKey func
cvictory File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,12 +17,9 @@ | |
|
||
package config | ||
|
||
import ( | ||
"github.com/creasty/defaults" | ||
) | ||
|
||
import ( | ||
"github.com/apache/dubbo-go/common/constant" | ||
"github.com/creasty/defaults" | ||
) | ||
|
||
// ApplicationConfig ... | ||
|
@@ -40,7 +37,7 @@ func (*ApplicationConfig) Prefix() string { | |
return constant.DUBBO + ".application." | ||
} | ||
|
||
// Id ... | ||
// ID ... | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if u do not wanna add comment here, pls add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok. It is keep the same as before. |
||
func (c *ApplicationConfig) Id() string { | ||
return "" | ||
} | ||
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok