-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider can get attachment in ctx #508
provider can get attachment in ctx #508
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #508 +/- ##
===========================================
+ Coverage 66.38% 66.43% +0.04%
===========================================
Files 184 184
Lines 9717 9720 +3
===========================================
+ Hits 6451 6457 +6
+ Misses 2626 2625 -1
+ Partials 640 638 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attachment本质上是key-value,如果只是把attachment里面的key-value拉平塞进去context,而不是直接塞整个attachment,这样是否可行?
这里主要是参照java的模式 java中是通过context.getAttachment()获取到一个map[string]string ,而且客户端发送attachment之前已经确定格式了 现在也不好改了 |
晚点合并,等 #495 合并完成之后,再在纸上修改吧。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result.SetAttachments(invocation.Attachments()) |
This line of code should be modified, otherwise modified attachment will not be returned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still failing. boss Pan
现在暂不考虑服务端修改的ctx返回,因为ctx的传值机制是新生成ctx对象,只能向下传递,暂时无法向上传递修改内容 |
What this PR does:
before this , consumer can send attachment from context
after this
Provider get attachment in context