Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add comments for config #579

Merged
merged 5 commits into from
Jun 3, 2020

Conversation

watermelo
Copy link
Member

What this PR does:
Add comments for config

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@watermelo
Copy link
Member Author

#566

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2020

Codecov Report

Merging #579 into develop will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #579      +/-   ##
===========================================
+ Coverage    66.43%   66.52%   +0.09%     
===========================================
  Files          184      184              
  Lines         9712     9709       -3     
===========================================
+ Hits          6452     6459       +7     
+ Misses        2620     2606      -14     
- Partials       640      644       +4     
Impacted Files Coverage Δ
config/application_config.go 55.55% <ø> (+13.88%) ⬆️
config/base_config.go 64.14% <ø> (ø)
config/config_center_config.go 71.42% <ø> (ø)
config/consumer_config.go 56.25% <ø> (ø)
config/generic_service.go 0.00% <ø> (ø)
config/graceful_shutdown.go 58.62% <ø> (ø)
config/graceful_shutdown_config.go 100.00% <ø> (ø)
config/metadata_report_config.go 48.71% <ø> (ø)
config/method_config.go 54.54% <ø> (ø)
config/mock_rpcservice.go 33.33% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af26b9...bada632. Read the comment docs.

@zouyx zouyx linked an issue Jun 2, 2020 that may be closed by this pull request
config/consumer_config.go Outdated Show resolved Hide resolved
config/graceful_shutdown.go Outdated Show resolved Hide resolved
config/interfaces/config_reader.go Outdated Show resolved Hide resolved
config/provider_config.go Outdated Show resolved Hide resolved
config/application_config.go Outdated Show resolved Hide resolved
config/base_config.go Outdated Show resolved Hide resolved
config/config_center_config.go Outdated Show resolved Hide resolved
config/graceful_shutdown.go Outdated Show resolved Hide resolved
config/graceful_shutdown_config.go Outdated Show resolved Hide resolved
config/method_config.go Outdated Show resolved Hide resolved
config/metadata_report_config.go Outdated Show resolved Hide resolved
config/method_config.go Outdated Show resolved Hide resolved
config/provider_config.go Outdated Show resolved Hide resolved
config/service_config.go Outdated Show resolved Hide resolved
@AlexStocks
Copy link
Contributor

LGTM

config/consumer_config.go Outdated Show resolved Hide resolved
config/reference_config.go Outdated Show resolved Hide resolved
config/registry_config.go Outdated Show resolved Hide resolved
@watermelo watermelo requested review from Patrick0308 and zouyx June 2, 2020 15:25
Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patrick0308 Patrick0308 merged commit 962025b into apache:develop Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] Add comments for config directory
6 participants