Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod: update the comments in filter directory #586

Merged

Conversation

williamfeng323
Copy link
Contributor

What this PR does:
Added comments to filter directory

Which issue(s) this PR fixes:
Fixes #569

@williamfeng323 williamfeng323 changed the title Feature/filter comment optimise Mod: update the comments in filter directory Jun 4, 2020
@williamfeng323 williamfeng323 force-pushed the feature/filter-comment-optimise branch from 106706c to b0c34c2 Compare June 4, 2020 16:17
@AlexStocks AlexStocks requested review from CodingSinger and flycash and removed request for CodingSinger June 4, 2020 16:21
@AlexStocks AlexStocks requested a review from zouyx June 4, 2020 16:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2020

Codecov Report

Merging #586 into develop will increase coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #586      +/-   ##
===========================================
+ Coverage    66.43%   66.68%   +0.25%     
===========================================
  Files          184      185       +1     
  Lines         9712     9749      +37     
===========================================
+ Hits          6452     6501      +49     
+ Misses        2620     2611       -9     
+ Partials       640      637       -3     
Impacted Files Coverage Δ
common/extension/auth.go 0.00% <ø> (ø)
filter/filter_impl/active_filter.go 66.66% <ø> (ø)
filter/filter_impl/auth/accesskey_storage.go 100.00% <ø> (ø)
filter/filter_impl/auth/consumer_sign.go 60.00% <ø> (ø)
filter/filter_impl/auth/default_authenticator.go 80.00% <ø> (ø)
filter/filter_impl/auth/provider_auth.go 52.94% <ø> (ø)
filter/filter_impl/auth/sign_util.go 69.23% <ø> (ø)
filter/filter_impl/echo_filter.go 85.71% <ø> (ø)
filter/filter_impl/execute_limit_filter.go 73.80% <ø> (ø)
filter/filter_impl/generic_filter.go 67.69% <ø> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af26b9...e03e24e. Read the comment docs.

common/extension/auth.go Outdated Show resolved Hide resolved
filter/filter_impl/graceful_shutdown_filter.go Outdated Show resolved Hide resolved
filter/filter_impl/graceful_shutdown_filter.go Outdated Show resolved Hide resolved
@zouyx zouyx linked an issue Jun 5, 2020 that may be closed by this pull request
@zouyx zouyx merged commit 36076fa into apache:develop Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] Add comments for filter directory
5 participants