Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Nacos client logDir path seperator #591

Merged
merged 3 commits into from
Jun 13, 2020

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jun 8, 2020

What this PR does:

  • fix logDir path seperator in Windows
  • fix unit test prepare script for Windows

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
no

fix(bat): fix unit test prepare script
@AlexStocks AlexStocks requested review from zouyx, Patrick0308, flycash and fangyincheng and removed request for zouyx June 8, 2020 16:35
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #591 into develop will increase coverage by 0.48%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #591      +/-   ##
===========================================
+ Coverage    66.80%   67.29%   +0.48%     
===========================================
  Files          185      188       +3     
  Lines         9749     9854     +105     
===========================================
+ Hits          6513     6631     +118     
+ Misses        2600     2574      -26     
- Partials       636      649      +13     
Impacted Files Coverage Δ
config/config_center_config.go 73.33% <100.00%> (+1.90%) ⬆️
config_center/nacos/client.go 75.42% <100.00%> (+19.86%) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 61.11% <0.00%> (-11.36%) ⬇️
cluster/directory/base_directory.go 56.81% <0.00%> (-9.10%) ⬇️
protocol/dubbo/listener.go 57.52% <0.00%> (-5.38%) ⬇️
protocol/dubbo/pool.go 76.81% <0.00%> (-4.55%) ⬇️
protocol/dubbo/client.go 67.87% <0.00%> (-1.22%) ⬇️
cluster/cluster_impl/failover_cluster_invoker.go 71.15% <0.00%> (-1.19%) ⬇️
cluster/cluster_impl/forking_cluster_invoker.go 58.33% <0.00%> (-0.21%) ⬇️
remoting/kubernetes/listener.go 52.83% <0.00%> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 106040d...79abeed. Read the comment docs.

config_center/nacos/client.go Outdated Show resolved Hide resolved
@AlbumenJ AlbumenJ requested a review from zouyx June 9, 2020 07:52
@AlexStocks AlexStocks merged commit 9dee25c into apache:develop Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants