Imp: Zk client #601
Merged
Imp: Zk client #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #601 +/- ##
=======================================================
- Coverage 66.16% 65.78% -0.38%
=======================================================
Files 204 204
Lines 10610 10604 -6
=======================================================
- Hits 7020 6976 -44
- Misses 2912 2951 +39
+ Partials 678 677 -1
Continue to review full report at Codecov.
|
AlexStocks
requested review from
pantianying and
CodingSinger
and removed request for
pantianying
AlexStocks
reviewed
Jun 13, 2020
remoting/zookeeper/client_test.go
Outdated
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| import ( | ||
| "github.com/dubbogo/go-zookeeper/zk" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" |
There was a problem hiding this comment.
I think u can rollback the testify/require to testify/assert package.
There was a problem hiding this comment.
an example
func TestSomething(t *testing.T) {
var err error
err = perrors.Errorf("something1")
assert.NoError(t, err)
err = perrors.Errorf("something2")
assert.NoError(t, err)
}- use
testify/assertwill output two errors on console:
=== RUN TestSomething
--- FAIL: TestSomething (0.00s)
client_test.go:151:
Error Trace: client_test.go:151
Error: Received unexpected error:
something1
github.com/apache/dubbo-go/remoting/zookeeper.TestSomething
D:/GoPath/src/github.com/apache/dubbo-go/remoting/zookeeper/client_test.go:150
testing.tRunner
D:/Go/src/testing/testing.go:909
runtime.goexit
D:/Go/src/runtime/asm_amd64.s:1357
Test: TestSomething
client_test.go:154:
Error Trace: client_test.go:154
Error: Received unexpected error:
something2
github.com/apache/dubbo-go/remoting/zookeeper.TestSomething
D:/GoPath/src/github.com/apache/dubbo-go/remoting/zookeeper/client_test.go:153
testing.tRunner
D:/Go/src/testing/testing.go:909
runtime.goexit
D:/Go/src/runtime/asm_amd64.s:1357
Test: TestSomething
FAIL
- use
testify/requirejust output the first error and stop the test case intermediately
why I prefer testify/require
- Because errors in test case may have some dependency: first error causes second error, then I think it's better to use
testify/require, which only shows the first error. - Using
testify/assertmay output too many errors, but developers only need to focus on fixing the first error.
There was a problem hiding this comment.
However, it is impossible that we test the same error case in one Testxxx.
There was a problem hiding this comment.
@AlexStocks Ok, I revert require to assert.
zouyx
approved these changes
Jun 13, 2020
AlexStocks
approved these changes
Jun 17, 2020
| @@ -42,21 +42,23 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| errNilZkClientConn = perrors.New("zookeeperclient{conn} is nil") | |||
| errNilZkClientConn = perrors.New("zookeeper client{conn} is nil") | |||
| errNilChildren = perrors.Errorf("has none children") | |||
| errNilNode = perrors.Errorf("node does not exist") | |||
| ) | |||
|
|
|||
| // ZookeeperClient ... | |||
There was a problem hiding this comment.
maybe u can add some comments for this struct or just using "nolint" instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
eventRegistryinZookeeperClientto avoid concurrent read and write in mapgit.luolix.top/stretchr/testify/assertwithgit.luolix.top/stretchr/testify/requirein test to fail test case immediately when test meet an error\nin logSpecial notes for your reviewer:
Does this PR introduce a user-facing change?: