Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: namespaceId config for nacos #641

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Add: namespaceId config for nacos #641

merged 1 commit into from
Jul 3, 2020

Conversation

coffeehc
Copy link
Contributor

@coffeehc coffeehc commented Jul 2, 2020

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on https://github.com/apache/dubbo-go/blob/master/contributing.md to change the title

Would you like to add some test for thi PR?

@AlexStocks AlexStocks changed the title add namespaceId config for nacos Add: namespaceId config for nacos Jul 3, 2020
@lzp0412
Copy link
Contributor

lzp0412 commented Jul 3, 2020

LGTM

@AlexStocks AlexStocks merged commit 9697b2b into apache:develop Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants